I'm fairly new to shell scripting, so I'd appreciate someone else to take a look to see if there are any loopholes or ways to optimize the script. I'm also wondering if it is ok to run the cron job even more often. The command executes very quickly so it doesn't seem like it would overload the server.
#!/bin/bash #This script finds files that have recently been modified and emails the results #Version 1.3 (March 6, 2010 at 15:45) #Directory to search myDir=~/public_html #Set frequency of command in minutes, this should match how often you run the cron job myFrequency='-30' #email address for mailing the results myEmailemail@example.com #Create datestamp for subject line #This makes each subject line unique to prevent message collapsing in Gmail myDate=`date +%y-%m-%d` myTime=`date +%H:%M` #Test if files have been edited fileCount=`find $myDir -mmin $myFrequency -type f | wc -l` if [ $fileCount -gt 0 ] then #Write the subject line and set correct form of the word "files" (singular or plural) if [ $fileCount -eq 1 ] then mySubject="Attention! $fileCount File Modified on $myDate at $myTime" else mySubject="Attention! $fileCount Files Modified on $myDate at $myTime" fi #execute find command and email the results find $myDir -mmin $myFrequency -type f | mail -s "$mySubject" $myEmail #else nothing happens fi